Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add containerd's docs directory #121

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

kzys
Copy link
Member

@kzys kzys commented Apr 5, 2022

Signed-off-by: Kazuyoshi Kato [email protected]

@kzys
Copy link
Member Author

kzys commented Apr 5, 2022

The preview website is https://deploy-preview-121--containerd-io.netlify.app/docs/latest/getting-started/.

Right now, it doesn't look great compared to #120, but we can improve the look & feel by adopting Hugo's documentation-oriented themes like https://www.docsy.dev/.

It would be better to not complicate the stack by having multiple documentation generators.

@kzys kzys marked this pull request as draft April 6, 2022 00:18
@kzys kzys marked this pull request as ready for review April 6, 2022 00:29
@AkihiroSuda
Copy link
Member

Can we remove /docs/getting-started and redirect it to /docs/latest/getting-started?

@AkihiroSuda
Copy link
Member

Seems broken

image

@kzys
Copy link
Member Author

kzys commented Apr 6, 2022

Fixed the broken menu.

Regarding the redirection, the Getting Started guide needs to have metadata like https://github.com/containerd/containerd.io/blob/main/content/docs/getting-started.md. Let me fix other parts first.

@AkihiroSuda
Copy link
Member

AkihiroSuda commented Apr 6, 2022

Fixed the broken menu.

The new docs don't seem reachable from the top page

It would be better to not complicate the stack by having multiple documentation generators.

If sphinx is easier to use than hugo, we can completely replace hugo with sphinx.
Just reopening #120, adding logo, and redirecting / to /docs/latest would be enough as the first step.

@kzys
Copy link
Member Author

kzys commented Apr 6, 2022

The new docs don't seem reachable from the top page

Yes. I'd like to add at least add <title> before making them reachable. But to do that, I need to edit files on containerd/containerd first.

If sphinx is easier to use than hugo, we can completely replace hugo with sphinx.

Honestly both are not that different in terms of the ease of use. Hugo may work better for us at this time since we already have Hugo-based website. Migrating that to Sphinx may not bring us much value.

@kzys kzys marked this pull request as draft April 6, 2022 16:19
@AkihiroSuda
Copy link
Member

Is this still planned?

@AkihiroSuda
Copy link
Member

AkihiroSuda commented Nov 26, 2022

@kzys
Copy link
Member Author

kzys commented Mar 17, 2023

I've updated this PR finally.

The preview site is https://deploy-preview-121--containerd-io.netlify.app/. The docs from containerd/containred is linked from https://deploy-preview-121--containerd-io.netlify.app/docs/getting-started/.

I'm planning to merge https://deploy-preview-121--containerd-io.netlify.app/docs/ and https://deploy-preview-121--containerd-io.netlify.app/docs/getting-started/, since the latter is pretty short.

@samuelkarp
Copy link
Member

I like this approach. It doesn't have to be in this PR, but we should also consider doing something like https://github.com/containerd/containerd.io/blob/main/.github/workflows/sync-releases.yml so it stays reasonably up-to-date too.

@haddscot
Copy link
Contributor

haddscot commented Mar 4, 2024

picking this up – gonna rebase and implement the doc syncing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

4 participants