Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.5] cherry-pick: Allow git commands in Vagrantfile #6943

Merged
merged 1 commit into from
May 13, 2022

Conversation

estesp
Copy link
Member

@estesp estesp commented May 13, 2022

Due to a git CVE, we need to mark /vagrant as a "safe" directory
otherwise building containerd inside Vagrant fails with git command
failures.

Cherry-pick of #6941

Signed-off-by: Phil Estes [email protected]

Due to a git CVE, we need to mark /vagrant as a "safe" directory
otherwise building containerd inside Vagrant fails with git command
failures.

Signed-off-by: Phil Estes <[email protected]>
(cherry picked from commit 06bdfeb)
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp
Copy link
Member Author

estesp commented May 13, 2022

/test pull-containerd-build

@k8s-ci-robot
Copy link

@estesp: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-containerd-build 1f99008 link true /test pull-containerd-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@estesp
Copy link
Member Author

estesp commented May 13, 2022

Looks like some auth issue with the prow-managed jobs (well, the build one at least):

gcloud auth activate-service-account --key-file /etc/service-account/service-account.json --project=k8s-cri-containerd
ERROR: (gcloud.auth.activate-service-account) There was a problem refreshing your current auth tokens: ('invalid_grant: Invalid JWT Signature.', {'error': 'invalid_grant', 'error_description': 'Invalid JWT Signature.'})

@dmcgowan dmcgowan merged commit 61ac3ae into containerd:release/1.5 May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants