Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestDiffDirChangeWithOverlayfs is failing (when TMPDIR is on tmpfs, not on ext4) #247

Closed
AkihiroSuda opened this issue Oct 20, 2024 · 3 comments · Fixed by #249
Closed
Labels

Comments

@AkihiroSuda
Copy link
Member

AkihiroSuda commented Oct 20, 2024

Interesting; looks like this is failing on go1.22

cc @AkihiroSuda @dmcgowan

=== RUN   TestDiffDirChangeWithOverlayfs
    diff_test.go:249: failed diff dir change: Unexpected number of changes:
        got(6):
        	modify	/dir1
        	delete	/dir1/d
        	modify	/dir1/f
        	modify	/dir2/d/f
        	modify	/dir3
        	delete	/dir3/.wh..opq
        expected(8):
        	modify	/dir1
        	delete	/dir1/d
        	modify	/dir1/f
        	modify	/dir2
        	modify	/dir2/d
        	modify	/dir2/d/f
        	modify	/dir3
        	delete	/dir3/.wh..opq
--- FAIL: TestDiffDirChangeWithOverlayfs (0.01s)

Originally posted by @thaJeztah in #242 (comment)

(Unlikely specific to Go 1.22)

@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Oct 24, 2024

Locally reproducible on Ubuntu 24.10 (kernel 6.11.0-9-generic #9-Ubuntu), but not reproducible on Ubuntu 24.04 (kernel 6.8.0-45-generic #45-Ubuntu) and Ubuntu 22.04 (kernel 5.15.0-122-generic #132-Ubuntu).

Not sure if this difference arises from the kernel version or some filesystem configuration.

@AkihiroSuda
Copy link
Member Author

Looks like the test depends on the filesystem of TMPDIR, not on the kernel version.

Works with:

  • /dev/vda1 on / type ext4 (rw,relatime,discard,errors=remount-ro,commit=30)

Fails with:

  • tmpfs on /tmp type tmpfs (rw,nosuid,nodev,size=2003352k,nr_inodes=1048576,inode64)

@AkihiroSuda AkihiroSuda changed the title TestDiffDirChangeWithOverlayfs is failing TestDiffDirChangeWithOverlayfs is failing (when TMPDIR is on tmpfs, not on ext4) Oct 25, 2024
@AkihiroSuda
Copy link
Member Author

PR #249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant