Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gha: run CI on go1.22 #242

Merged
merged 1 commit into from
Oct 26, 2024
Merged

gha: run CI on go1.22 #242

merged 1 commit into from
Oct 26, 2024

Conversation

thaJeztah
Copy link
Member

No description provided.

@thaJeztah thaJeztah self-assigned this Jun 22, 2024
@thaJeztah thaJeztah closed this Jun 22, 2024
@thaJeztah thaJeztah reopened this Jun 22, 2024
@thaJeztah
Copy link
Member Author

thaJeztah commented Jun 22, 2024 •
edited
Loading

Interesting; looks like this is failing on go1.22

cc @AkihiroSuda @dmcgowan

=== RUN   TestDiffDirChangeWithOverlayfs
    diff_test.go:249: failed diff dir change: Unexpected number of changes:
        got(6):
        	modify	/dir1
        	delete	/dir1/d
        	modify	/dir1/f
        	modify	/dir2/d/f
        	modify	/dir3
        	delete	/dir3/.wh..opq
        expected(8):
        	modify	/dir1
        	delete	/dir1/d
        	modify	/dir1/f
        	modify	/dir2
        	modify	/dir2/d
        	modify	/dir2/d/f
        	modify	/dir3
        	delete	/dir3/.wh..opq
--- FAIL: TestDiffDirChangeWithOverlayfs (0.01s)

@thaJeztah thaJeztah mentioned this pull request Jul 25, 2024
Merged
@AkihiroSuda AkihiroSuda mentioned this pull request Oct 20, 2024
Closed
@thaJeztah
gha: run CI on go1.22
f0f6869 
Signed-off-by: Sebastiaan van Stijn <[email protected]>
AkihiroSuda
AkihiroSuda reviewed Oct 26, 2024
View reviewed changes
cmd/continuity/go.mod
@@ -1,6 +1,6 @@
module github.com/containerd/continuity/cmd/continuity

go 1.17
go 1.19
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It uses a replace rule for the main module (github.com/containerd/continuity), and the main module requires go 1.19 as minimum.

continuity/go.mod

Lines 1 to 3 in 898d7ed

module github.com/containerd/continuity
go 1.19

@AkihiroSuda AkihiroSuda merged commit e372ae5 into containerd:main Oct 26, 2024
13 checks passed
@thaJeztah thaJeztah deleted the bump_go branch October 26, 2024 08:49
@thaJeztah thaJeztah mentioned this pull request Oct 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@dmcgowan dmcgowan Awaiting requested review from dmcgowan

Assignees

@thaJeztah thaJeztah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thaJeztah @AkihiroSuda