Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assorted linting fixes and minor cleanups #259

Merged
merged 6 commits into from
Oct 28, 2024

Conversation

thaJeztah
Copy link
Member

    WARN [lintersdb] The name "vet" is deprecated. The linter has been renamed to: govet.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
    commands/mount_unsupported.go:26:31: var-declaration: should drop = nil from declaration of var MountCmd; it is the zero value (revive)
    var MountCmd *cobra.Command = nil
                                  ^

Signed-off-by: Sebastiaan van Stijn <[email protected]>
ctx is commonly used for context.Context. Using it for any other purpose
should be avoided to prevent confusion.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@AkihiroSuda AkihiroSuda merged commit 0e83ada into containerd:main Oct 28, 2024
13 checks passed
@thaJeztah thaJeztah deleted the fix_lint_step1 branch October 28, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants