This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io.Copy
doesn't work for us. The main problem is that:io.Copy
use that side as source will close, but theio.Copy
use that side as dest won't. (io.Copy
doesn't stop when dest is closed until there is new input from source)io.Copy
by closing the source. Because TCP is bi-direction, even though one direction is closed (we know because oneio.Copy
stops), the other direction may not, and thatio.Copy
might be working. There is no way for us to know it now.There should be some solution for this problem, and socat must have implemented that. We need more time to investigate it.
So let's switch back to
socat
for this release.@abhi
Signed-off-by: Lantao Liu [email protected]