Re-introduce serial network setup #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some use cases require serialized network setup to ensure proper network namespace switching on the same thread.
As
ns.Set()cannot be relied upon when goroutines switch OS threads callers ofCNI.Setup(...)may want to wrap the setup network creation in a closure locking the OS thread, as described here: https://github.com/containernetworking/plugins/tree/main/pkg/ns#do-the-recommended-thingFor more details and background also see https://github.com/containernetworking/plugins/tree/main/pkg/ns#namespace-switching
With the performance improvements introduced with PR76 such use cases break.
This PR re-introduces an additional serialized version
SetupSerially(...)of CNI network setup/attach to accommodate the above mentioned use cases, while leaving the main code path untouched to ensure the non-edge cases can benefit from the performance recent enhancement.