golang: add test coverage, and fix handling of files with multiple build-tags #14
Conversation
thaJeztah
changed the title
Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
This is ready for review; @kunalkushwaha @AkihiroSuda @estesp PTAL (easiest to step through each commit - I tried to outline/describe each change I made) |
|
@kunalkushwaha PTAL 🙏 |
|
@kunalkushwaha @AkihiroSuda ptal 🤗 |
| } | ||
| if strings.HasPrefix(string(buf2), "// +build ") { | ||
| buildTags = append(buildTags, string(buf2)) | ||
| } |
There was a problem hiding this comment.
I think you want an else break case here?
There was a problem hiding this comment.
ah, yes, doesn't hurt I guess 😄
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
This looks to be how it's used in current projects; also add a test- case with a single build-tag. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
fix_golang
branch
from
e08e593
to
9f81529
Compare
|
@mikebrow updated; PTAL |
|
@kunalkushwaha PTAL - wondering if you would be open to transferring this repository to the containerd org and/or integrate it into https://github.com/containerd/project-checks |
|
Hi @thaJeztah , Sure. Sorry for not being active with the PRs. Moved to other work with a change in my organization. |
|
LGTM |
|
Hi @thaJeztah , I am not able to transfer this project to containerd org. Please help in transferring the project. |
|
Ah, yes probably needs an admin for the containerd org; @dmcgowan are you able to help with that (if we're okay with moving the repo that is) |
|
Yeah, I can help you get that moved. There are a few different options, you can give me admin on this repo or I can get you into the containerd org for the transfer. You can also try to transfer it to me, I don't think the transfer requests work anymore to orgs, only to other users. |
|
Thanks @thaJeztah. @dmcgowan : I made a request to transfer this repo to your user. Please take it forward. |
|
Done! Thanks |
See individual commits for details