Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nerdctl do not support ipv6 yet #183

Closed
wants to merge 1 commit into from

Conversation

fahedouch
Copy link
Member

fixing #182

Signed-off-by: fahed dorgaa [email protected]

@fahedouch fahedouch changed the title ipv6 support nerdctl nerdctl do not support ipv6 yet Apr 22, 2021
@fahedouch fahedouch force-pushed the fix-test-output branch 2 times, most recently from 5c19fb4 to ea86c77 Compare April 22, 2021 19:14
Signed-off-by: fahed dorgaa <[email protected]>
@@ -25,6 +25,8 @@ import (
)

func TestContainerInspectContainsPortConfig(t *testing.T) {
//nerdctl do not support yet ipv6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has nothing to with testutil.DockerIncompatible. And this test should pass with Docker.

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTLGTM

@AkihiroSuda
Copy link
Member

#185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants