Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove is shareable test #3456

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

Shubhranshu153
Copy link
Contributor

Based on discussions in #3451

Signed-off-by: Shubharanshu Mahapatra <[email protected]>
@Shubhranshu153
Copy link
Contributor Author

tentatively created this pull request based on the conversation in #3451 (comment)

technically i dont see the risk as long as builds are successful and that is already tested.
@apostasie

@apostasie
Copy link
Contributor

Thanks @Shubhranshu153

As outlined in the ticket, I have no gripe against the existence of the test itself :-).

I am fine with removing it of course if it serves no purpose (haven't looked closely into unit tests around that).

@Shubhranshu153
Copy link
Contributor Author

The test is checking if the image built is shareable in case the target platform and the platform it is built on matches, Before the pr we used to tar and load it if the --platform option was provided even if the platform matches for the build system.

@AkihiroSuda would like some suggestion weather to refactor this test to be more robust (and also fix the bug) or we want to remove it altogether. Unit test are there but the exact test is not there in E2E setup.

@Shubhranshu153
Copy link
Contributor Author

Checking back on this if we want to remove it or refactor it.
Thanks.

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Oct 5, 2024
@AkihiroSuda AkihiroSuda merged commit 394015b into containerd:main Oct 5, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants