Add --blkio-weight option to run subcommand #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Falzoi <[email protected]>
Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR aims to add the
--blkio-weightoption tonerdctl run, exposing the same behaviour asdocker run --blkio-weightBoth cgroup v1 and cgroup v2 are supported. Besides, since the bfq IO scheduler exposes a different weight knob, a specific check is added for that.
Just like in docker, if the underlying kernel does not support blkio weight, a warning is generated and the weight is reset to 0.
Updates #215