support overriding image CMD on commit #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomfeigin
force-pushed
the
override_cmd_on_commit
branch
from
ccc4179
to
2db428e
Compare
|
Thanks, but please sign the commit for DCO (run |
AkihiroSuda
reviewed
Nov 22, 2021
cmd/nerdctl/commit.go
Outdated
| @@ -39,6 +39,7 @@ func newCommitCommand() *cobra.Command { | |||
| } | |||
| commitCommand.Flags().StringP("author", "a", "", `Author (e.g., "nerdctl contributor <[email protected]>")`) | |||
| commitCommand.Flags().StringP("message", "m", "", "Commit message") | |||
| commitCommand.Flags().StringSlice("override-cmd", nil, "Override image CMD") | |||
There was a problem hiding this comment.
This should be like --change='CMD ["apachectl", "-DFOREGROUND"]'
https://docs.docker.com/engine/reference/commandline/commit/
tomfeigin
force-pushed
the
override_cmd_on_commit
branch
4 times, most recently
from
c094fe6
to
a2cdf40
Compare
|
Please squash commits ( |
AkihiroSuda
reviewed
Nov 22, 2021
cmd/nerdctl/commit.go
Outdated
| @@ -39,6 +41,7 @@ func newCommitCommand() *cobra.Command { | |||
| } | |||
| commitCommand.Flags().StringP("author", "a", "", `Author (e.g., "nerdctl contributor <[email protected]>")`) | |||
| commitCommand.Flags().StringP("message", "m", "", "Commit message") | |||
| commitCommand.Flags().StringSliceP("change", "c", nil, "Apply Dockerfile instruction to the created image") | |||
There was a problem hiding this comment.
The help string should describe that only CMD instruction is supported currently.
tomfeigin
force-pushed
the
override_cmd_on_commit
branch
from
a2cdf40
to
88b5ee6
Compare
Support supplying a CMD to override when committing an image Signed-off-by: Tom Feigin <[email protected]>
tomfeigin
force-pushed
the
override_cmd_on_commit
branch
from
88b5ee6
to
91b95a7
Compare
|
Adding docs in #572 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for supplying a CMD to override when committing an image