load cmd support gzip #587
Conversation
| in = bzip2.NewReader(inbuf) | ||
| } else { | ||
| in = inbuf | ||
| } |
There was a problem hiding this comment.
Thanks for working on this, but I'd suggest using https://pkg.go.dev/github.com/containerd/containerd/archive/compression#DecompressStream
There was a problem hiding this comment.
DecompressStream only supports gzip and zstd.
https://github.com/containerd/containerd/blob/main/archive/compression/compression.go#L169
but docker load support gzip and bzip2.
https://docs.docker.com/engine/reference/commandline/load/#extended-description
There was a problem hiding this comment.
Then we should fix containerd/containerd
There was a problem hiding this comment.
Anyway, supporting bzip2 is probably not important. Is anyone really using bzip2 for Docker v1 archives?
There was a problem hiding this comment.
@AkihiroSuda I first change to usingDecompressStream.
Signed-off-by: ye.sijun <[email protected]>
Fixes #581