Skip to content

Commit

Permalink
api,adaptation,stub: let plugin know configured timeouts.
Browse files Browse the repository at this point in the history
Let plugins know the configured registration and request
processing timeout.

Signed-off-by: Krisztian Litkey <[email protected]>
  • Loading branch information
klihub committed Sep 20, 2024
1 parent 2450545 commit 1207e68
Show file tree
Hide file tree
Showing 5 changed files with 639 additions and 552 deletions.
12 changes: 7 additions & 5 deletions pkg/adaptation/plugin.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ import (

const (
// DefaultPluginRegistrationTimeout is the default timeout for plugin registration.
DefaultPluginRegistrationTimeout = 5 * time.Second
DefaultPluginRegistrationTimeout = api.DefaultPluginRegistrationTimeout
// DefaultPluginRequestTimeout is the default timeout for plugins to handle a request.
DefaultPluginRequestTimeout = 2 * time.Second
DefaultPluginRequestTimeout = api.DefaultPluginRequestTimeout
)

var (
Expand Down Expand Up @@ -384,9 +384,11 @@ func (p *plugin) configure(ctx context.Context, name, version, config string) er
defer cancel()

rpl, err := p.stub.Configure(ctx, &ConfigureRequest{
Config: config,
RuntimeName: name,
RuntimeVersion: version,
Config: config,
RuntimeName: name,
RuntimeVersion: version,
RegistrationTimeout: getPluginRegistrationTimeout().Milliseconds(),
RequestTimeout: getPluginRequestTimeout().Milliseconds(),
})
if err != nil {
return fmt.Errorf("failed to configure plugin: %w", err)
Expand Down
Loading

0 comments on commit 1207e68

Please sign in to comment.