-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset source path of api.pb.go to pkg/api/api.proto #104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wave .. it happens.. :)
My bad, I didn't open the proto generated file to look over / review the diff..
Also the versioning for your build is off as set by the makefile helpers
FYI these are the versions being used by containerd .. protobuf version v3.20.1 and protoc v1.28.0
https://github.com/containerd/nri/blob/main/scripts/install-protobuf#L23
https://github.com/containerd/nri/blob/main/Makefile#L188
Signed-off-by: Xiaojin Zhang <[email protected]>
Fixed withprotobuf version v3.20.1 and protoc v1.28.0 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zxj874478410 Normally, you should not need to do manually proto-compile anything. The Makefile has the necessary dependencies and targets to automatically proto-compile if the proto-file changes. The plugins don't get recompiled in that case without a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Source path of api.pb.go is changed in #94 . This changes the variable naming in the file.
Tix this by regenerate api.proto.