api: pass configured timeouts to plugins. #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @zhaodiaoer |
|
/cc @kad |
klihub
force-pushed
the
devel/pass-timeouts-to-plugins
branch
3 times, most recently
from
4661a25
to
1b879ca
Compare
mikebrow
reviewed
Sep 20, 2024
LGTM This is exactly what we need. The plugin owner can use these configurations more conveniently to adjust the context of the internal logic. Thanks. |
klihub
force-pushed
the
devel/pass-timeouts-to-plugins
branch
2 times, most recently
from
3178104
to
37b9262
Compare
klihub
force-pushed
the
devel/pass-timeouts-to-plugins
branch
3 times, most recently
from
111292b
to
3b04b20
Compare
klihub
force-pushed
the
devel/pass-timeouts-to-plugins
branch
5 times, most recently
from
24d6c98
to
147ff6a
Compare
Add a mechanism to block and unblock plugin synchronization. We use this first in our tests to ensure that test plugins get properly synchronized either before or after we create a pod or a container, but not halfway through it. We should also do the same in the corresponding paths of the NRI runtime integration core where otherwise processing NRI events concurrent to plugin registration could result in an inconsistent initial state of a new plugin (missing pods or containers during sync, or omitted event for the plugin). Signed-off-by: Krisztian Litkey <[email protected]>
Block plugin sync/registration in mocked test suite runtime. Signed-off-by: Krisztian Litkey <[email protected]>
Don't ignore ginkgo test run exit status. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
devel/pass-timeouts-to-plugins
branch
2 times, most recently
from
343f59a
to
6c5f46a
Compare
Let plugins know the configured registration and request processing timeout. Signed-off-by: Krisztian Litkey <[email protected]>
Add tests for passing runtime version and configured timeouts to plugins. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
devel/pass-timeouts-to-plugins
branch
from
6c5f46a
to
320e4e7
Compare
|
@fuweid PTAL |
dmcgowan
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass configured registration and request timeouts to plugins in the
Configurerequest.