Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the OCI Hook Injector README to resovle broken links to the p… #34

Merged
merged 2 commits into from
May 23, 2023

Conversation

swgriffith
Copy link
Contributor

Resolves issue #33

Updates the links to podman documentation to reference the proper sha1 and adds additional details to help guide people in testing the hook-injector plugin, including relevant path details.

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.16 🎉

Comparison is base (2a8b655) 63.83% compared to head (57cfa26) 64.00%.

❗ Current head 57cfa26 differs from pull request most recent head c783fc7. Consider uploading reports for the commit c783fc7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   63.83%   64.00%   +0.16%     
==========================================
  Files           9        9              
  Lines        1800     1800              
==========================================
+ Hits         1149     1152       +3     
+ Misses        500      497       -3     
  Partials      151      151              

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@swgriffith swgriffith force-pushed the hook-injector-docupdate branch 2 times, most recently from a29d526 to 6e4467a Compare March 14, 2023 21:08
Copy link
Member

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the fixes !

@kad
Copy link

kad commented Mar 15, 2023

Maybe it would be more sense to point to top of the tree like https://github.com/containers/common/tree/main/pkg/hooks and https://github.com/containers/common/blob/main/pkg/hooks/docs/oci-hooks.5.md instead of some older commit id in podman repo?

@klihub
Copy link
Member

klihub commented Mar 15, 2023

Maybe it would be more sense to point to top of the tree like https://github.com/containers/common/tree/main/pkg/hooks and https://github.com/containers/common/blob/main/pkg/hooks/docs/oci-hooks.5.md instead of some older commit id in podman repo?

We deliberately chose to point to the exact version we use in the plugin. That is then a different story that we should really file another PR to update the plugin to use a recent version, and then (remember to) update the link in the same PR as well.

@swgriffith
Copy link
Contributor Author

@klihub and @kad - It sounds like we're leaving it as is. Let me know if you need me to change the URLs.

@kad
Copy link

kad commented Mar 16, 2023

I'm ok with @klihub opinion, so lgtm.

@klihub klihub requested a review from fuweid April 4, 2023 07:52
Signed-off-by: Steve Griffith <[email protected]>
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM thanks!

@mikebrow mikebrow merged commit fa3ab8f into containerd:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants