misc: add daemon_mode option to guest pull config #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`daemon_mode` should be specified in guest pull config, even if it is none. This ensures that guest pull config is consistent with other configs and avoids confusion. Fixes containerd#568 Signed-off-by: ChengyuZhu6 <[email protected]>
Delete blank lines in snapshotter config. Signed-off-by: ChengyuZhu6 <[email protected]>
Add comments for daemon_mode on snapshotter config. Signed-off-by: ChengyuZhu6 <[email protected]>
loheagn
pushed a commit
to loheagn/nydus-snapshotter
that referenced
this pull request
Dec 24, 2023
misc: add daemon_mode option to guest pull config Signed-off-by: loheagn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
daemon_modeshould be specified in guest pull config, even if it is none.This ensures that guest pull config is consistent with other configs and avoids confusion.
Fixes #568