Remove DumpFile operations #616
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fappy1234567
commented
Sep 11, 2024
fappy1234567
commented
- Modify operations to use memory instead of disk
fappy1234567
force-pushed
the
no-disk-write
branch
2 times, most recently
from
eb1526a
to
606c148
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #616 +/- ##
==========================================
+ Coverage 21.82% 21.93% +0.10%
==========================================
Files 122 122
Lines 10730 10836 +106
==========================================
+ Hits 2342 2377 +35
- Misses 8070 8137 +67
- Partials 318 322 +4
|
fappy1234567
force-pushed
the
no-disk-write
branch
27 times, most recently
from
a507f6b
to
e272e20
Compare
fappy1234567
force-pushed
the
no-disk-write
branch
14 times, most recently
from
c93d8c7
to
30edd41
Compare
fappy1234567
changed the title
imeoer
reviewed
Sep 25, 2024
misc/snapshotter/Dockerfile
Outdated
| @@ -16,8 +16,11 @@ RUN apk add -q --no-cache curl && \ | |||
| FROM base AS kubectl-sourcer | |||
| ARG TARGETARCH | |||
|
|
|||
| # RUN apk add -q --no-cache curl && \ | |||
| # curl -fsSL -o /usr/bin/kubectl https://storage.googleapis.com/kubernetes-release/release/"$(curl -L -s https://dl.k8s.io/release/stable.txt)"/bin/linux/"$TARGETARCH"/kubectl && \ | |||
| # chmod +x /usr/bin/kubectl | |||
There was a problem hiding this comment.
Should remove the useless codes.
pkg/filesystem/fs.go
Outdated
| snapshotID := supplementInfo.SnapshotID | ||
| labels := supplementInfo.Labels | ||
| params := supplementInfo.Params | ||
| err = daemonconfig.SupplementDaemonConfig(cfg, imageID, snapshotID, false, labels, params) |
There was a problem hiding this comment.
Should we pass the entire supplementInfo to SupplementDaemonConfig?
tests/helpers/helpers.sh
Outdated
| @@ -99,7 +99,8 @@ install::kind(){ | |||
| } | |||
|
|
|||
| install::kubectl(){ | |||
| local version="${1:-}" | |||
| #local version="${1:-}" | |||
fappy1234567
force-pushed
the
no-disk-write
branch
10 times, most recently
from
f817433
to
96575e2
Compare
fappy1234567
force-pushed
the
no-disk-write
branch
from
96575e2
to
437b404
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.