Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'*.go': ditch import path checks. #1

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

klihub
Copy link
Member

@klihub klihub commented Mar 4, 2024

Remove golang 'custom import path check' comments. It's a pure accident (of the monkey see monkey do type) that we have them. They reportedly break RPM package building for some otelttrpc downstream consumers.

Remove golang 'custom import path check' comments. It's a pure
accident (of the monkey see monkey do type) that we have them.
They reportedly break RPM package building for some otelttrpc
downstream consumers.

Signed-off-by: Krisztian Litkey <[email protected]>
@klihub klihub assigned fuweid and dmcgowan and unassigned dmcgowan and fuweid Mar 4, 2024
@klihub klihub requested review from dmcgowan and fuweid March 4, 2024 15:18
Copy link

@kwilczynski kwilczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for taking care of this! 🚀

@kwilczynski
Copy link

/approve
/lgtm

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit ea5083f into containerd:main Mar 5, 2024
7 checks passed
@klihub klihub deleted the fixes/ditch-import-path-checks branch March 5, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants