[EROFS]: cleanup and introduce prefetch feature #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the global variables `_target` and `_source`, and introduce `struct liberofs_file` to wrap the source and target files. Signed-off-by: Hongzhen Luo <[email protected]>
salvete
changed the title
salvete
force-pushed
the
main
branch
2 times, most recently
from
e33fb96
to
102aba0
Compare
BigVan
reviewed
Aug 14, 2024
| @@ -493,7 +499,11 @@ class DynamicPrefetcher : public PrefetcherImpl { | |||
| } | |||
|
|
|||
| virtual int replay(const IFile *imagefile) override { | |||
|
|
|||
| if (is_erofs_fs(imagefile)) | |||
There was a problem hiding this comment.
unnecessary spaces?
done.
| @@ -78,3 +79,13 @@ photon::fs::IFileSystem *create_ext4fs(photon::fs::IFile *imgfile, bool mkfs, | |||
| } | |||
| return target; | |||
| } | |||
|
|
|||
| bool is_erofs_fs(const photon::fs::IFile *imgfile) | |||
| { | |||
There was a problem hiding this comment.
shall we check if imgfile == nullptr?
There was a problem hiding this comment.
shall we check if imgfile == nullptr?
done.
To support dynamic prefetching, EROFS provides the following interfaces: - ErofsFileSystem: - open - stat - opendir - ErofsFile: - fstat - fiemap - ErofsDir: - get - next - closedir - rewinddir - seekdir - telldir Signed-off-by: Hongzhen Luo <[email protected]>
4 tasks
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
_targetand_source, and introducestruct liberofs_fileto wrap the source and target files.The corresponding accelerated-container-image PR:
containerd/accelerated-container-image#299
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Please check the following list: