Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maintainer list #347

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Update maintainer list #347

merged 1 commit into from
Sep 3, 2024

Conversation

BigVan
Copy link
Member

@BigVan BigVan commented Aug 28, 2024

Hi guys~
These developers have contributed lots of code and proposals to this project. I would like to invite them as project maintainers:

  • invite @salvete as a committer
    Luo is the core developer responsible for supporting EROFS on overlaybd, having implemented numerous features for overlaybd based on the mainline kernel-erofs and erofs-utils.

  • invite @hsiangkao as a reviewer.
    Gao is the author of EROFS and has also proposed numerous reviews for its integration with OverlayBD.

Needs explicit LGTM from @hsiangkao @salvete and 1/3 of the 'overlaybd' Committers.
according to https://github.com/containerd/project/blob/main/GOVERNANCE.md :

After a candidate has been informally proposed in the maintainers forum, the
existing maintainers are given seven days to discuss the candidate, raise
objections and show their support. Formal voting takes place on a pull request
that adds the contributor to the MAINTAINERS file. Candidates must be approved
by 2/3 of the current committers by adding their approval or LGTM to the pull
request. The reviewer role has the same process but only requires 1/3 of current
committers.

If a candidate is approved, they will be invited to add their own LGTM or
approval to the pull request to acknowledge their agreement. A committer will
verify the numbers of votes that have been received and the allotted seven days
have passed, then merge the pull request and invite the contributor to the
organization.

For non-core sub-projects, only committers of the repository that the candidate
is proposed for are given votes.

I'd also like to get a few LGTMs from the Core Committers too. (not necessary)

Signed-off-by: Yifan Yuan <[email protected]>
@BigVan
Copy link
Member Author

BigVan commented Aug 28, 2024

LGTM

3 similar comments
@salvete
Copy link
Contributor

salvete commented Aug 28, 2024

LGTM

@hsiangkao
Copy link
Contributor

LGTM

@liulanzheng
Copy link
Member

LGTM

@BigVan
Copy link
Member Author

BigVan commented Aug 28, 2024

@dmcgowan @AkihiroSuda @fuweid
Please take a review :D

@dmcgowan dmcgowan merged commit 579b72d into containerd:main Sep 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants