[feat.] Support uploading 'output' to registry while merging layers #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WaberZhuang please take a review |
WaberZhuang
suggested changes
Sep 3, 2024
src/tools/comm_func.cpp
Outdated
| @@ -91,3 +92,21 @@ photon::fs::IFileSystem *create_erofs_fs(photon::fs::IFile *imgfile, uint64_t bl | |||
| { | |||
| return erofs_create_fs(imgfile, blksz); | |||
| } | |||
| IFile *create_uploader(ZFile::CompressArgs *zfile_args, IFile *src, | |||
| const string &upload_url, const string &cred_file_path, uint64_t timeout, uint64_t upload_bs_KB){ | |||
There was a problem hiding this comment.
use 'timeout_minute' instead of 'timeout' here, for consistency with the interface argument list
src/tools/overlaybd-commit.cpp
Outdated
| @@ -85,7 +85,7 @@ int main(int argc, char **argv) { | |||
| app.add_option("--compress_threads", compress_threads, "compress threads")->default_val(1); | |||
| app.add_flag("--verbose", verbose, "output debug info")->default_val(false); | |||
| app.add_option("--upload", upload_url, "registry upload url"); | |||
| app.add_option("--upload_bs", upload_bs, "block size for upload, in KB"); | |||
| app.add_option("--upload_bs", upload_bs, "block size for upload, in KB")->default_val(65536); // 64MB | |||
There was a problem hiding this comment.
NIT: remove the initial value when declaring
// ssize_t upload_bs = 262144;
ssize_t upload_bs = 0;
BigVan
force-pushed
the
main
branch
4 times, most recently
from
1f0d454
to
72867de
Compare
Signed-off-by: Yifan Yuan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
[fix.] enable zfile compress in overlaybd-merge
[feat.] support uploading 'output' to the remote registry while merging layers
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #348
Please check the following list: