Cleanup plugin interface #2
Conversation
Separate Get for set and init context, which are used differently. Ensure init context always returns instances and does not return an underlying map. Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
cleanup-plugin-interface
branch
from
011f099
to
cc7b82b
Compare
Remove the `Get` which just returns the first instance while ignoring other instances. GetSingle will ensure that there is only a single instance of a plugin and allow dependencies to enforce it or have logic to select the right plugin. Signed-off-by: Derek McGowan <[email protected]>
|
@samuelkarp Added a commit which changes the interface. I think this might be safer in the long run to enforce getting a single instance or selecting the right instance. Just getting the first instance from an unordered map is the kind of undefined behavior we want to avoid. |
This is a new module with a new import path, so users already will need to opt-in to use it. I think this is a reasonable change to make before we make a first release. |
|
We kind of have a one time chance when switching import path/modules. Although some packages stay under 1.0 in libraries to make it easier to change. I think in practice we won't need to make any other changes anytime soon for this part of the interface. |
Separate Get for set and init context, which are used differently.
Ensure init context always returns instances and does not return an underlying map.
Update these interfaces before tagging v0.1.0 release
Related to containerd/containerd#9258