Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Akhil as reviewer #123

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Add Akhil as reviewer #123

merged 1 commit into from
Nov 17, 2023

Conversation

dmcgowan
Copy link
Member

@dmcgowan dmcgowan commented Nov 8, 2023

Akhil has been as reviewer. He has been contributing to containerd for awhile and I must apologize as he was so active I thought we already added him as reviewer. This PR is long overdue!

New reviewers require a 1/3 vote of committers. From 11 committers, 4 must approve + new reviewer:

Signed-off-by: Derek McGowan <[email protected]>
@dmcgowan
Copy link
Member Author

dmcgowan commented Nov 8, 2023

LGTM from Akhiro next to me at the Kubecon booth 😄

@akhilerm
Copy link
Member

akhilerm commented Nov 8, 2023

LGTM

Thank you .

Copy link
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! LGTM

Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow
Copy link
Member

mikebrow commented Nov 9, 2023

Not fair I wanted to push this PR ;-)

Copy link
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome!

@dmcgowan dmcgowan merged commit 565da8e into containerd:main Nov 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants