Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-core subproject status changes #86

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

mikebrow
Copy link
Member

@mikebrow mikebrow commented Mar 21, 2022

Address #36

Merge Approval Requires 2/3 of the current committers (8 votes)

Signed-off-by: Mike Brown [email protected]

GOVERNANCE.md Outdated Show resolved Hide resolved
@mikebrow mikebrow changed the title non-core subproject status changes [wip] non-core subproject status changes Mar 22, 2022
Co-authored-by: Samuel Karp <[email protected]>
Signed-off-by: Mike Brown <[email protected]>
@mikebrow mikebrow changed the title [wip] non-core subproject status changes non-core subproject status changes Feb 6, 2023
Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

raise objections and cast their vote. Project changes of this type must be approved
by 2/3 of the current core committers and core committers are encouraged to consider the opinions and objections of the existing non-core project maintainers.

Project status changes do not automatically change the status of any non-core project maintainers. Project status change proposals may be accompanied by additional proposals to change individual maintainer status, subject to the existing rules set forth in this document.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: wrapping is not right here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah md doesn't care, the view gets updated when it is loaded.. more a convention to insert extra line breaks or not

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow mikebrow merged commit 428e1cf into containerd:main Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants