Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oci-tar-builder/Cargo: remove native-tls deps #683

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Sep 30, 2024

removes the native-tls dependency from oci-tar-builder and uses rustls-tls instead. This is done to avoid the openssl dependency

note that: if the opentelemetry feature is turned on, the containerd-shim-wasm crate will still use native-tls due to the fact that opentelemetry-http uses the default features of reqwest. See more on open-telemetry/opentelemetry-rust#936.

removes the native-tls dependency from oci-tar-builder and uses
rustls-tls instead. This is done to avoid the openssl dependency
@Mossaka Mossaka marked this pull request as ready for review October 1, 2024 17:43
@Mossaka Mossaka closed this Oct 1, 2024
@Mossaka Mossaka reopened this Oct 1, 2024
@Mossaka Mossaka requested a review from cpuguy83 October 2, 2024 03:42
@cpuguy83 cpuguy83 merged commit fbd1e98 into containerd:main Oct 2, 2024
76 of 88 checks passed
@Mossaka Mossaka deleted the use-rustls-tls branch October 2, 2024 16:40
Mossaka added a commit to Mossaka/runwasi that referenced this pull request Oct 2, 2024
Mossaka added a commit that referenced this pull request Oct 2, 2024
containerd-shim-wasm/CHANGELOG: add #683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants