Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add forced exit into makefile #686

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

fawadasaurus
Copy link
Contributor

No description provided.

@fawadasaurus fawadasaurus marked this pull request as draft October 2, 2024 00:24
@jprendes
Copy link
Collaborator

jprendes commented Oct 2, 2024

I believe this is already the default behavior of make, i.e., to stop after any non-zero exit code.

I think the problem with CI is somewhere else.

According to this you need to explicitly do something to allow make to continue after a failure.

@fawadasaurus
Copy link
Contributor Author

Yea, I have tested different variations and I believe that the issue is not with Make or Github Actions.

That means that the issue is likely with cross-rs not properly propagating errors from inside the docker container. I will do more experimentation to try to figure it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants