Enable to sync registry creds by proxying CRI #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
May 18, 2021
AkihiroSuda
reviewed
May 18, 2021
Though stargz snpashotter supports kubeconfig-based authentication on Kuberentes, this has some drawbacks including that it requires additional permission (listing/watching secrets) to the node. For solving this issue, this commit introduces an alternative authentication method based on CRI proxy. This allows stargz snapshotter to work as a proxy of CRI Image Service. The snapshotter exposes CRI Image Service API on its unix socket (i.e. `/run/containerd-stargz-grpc/containerd-stargz-grpc.sock`). Stargz Snapshotter acquires registry creds by scanning requests on CRI ImagePull API. The following configuration enables this authentication mode. `--image-service-endpoint=unix:///run/containerd-stargz-grpc/containerd-stargz-grpc.sock` option is needed to kubelet. ```toml [cri_keychain] enable_keychain = true image_service_path = "/run/containerd/containerd.sock" ``` Signed-off-by: Kohei Tokunaga <[email protected]>
AkihiroSuda
approved these changes
May 20, 2021
This was referenced May 20, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #270
Though stargz snpashotter supports kubeconfig-based authentication on Kuberentes, this has some drawbacks including that it requires additional permission (listing/watching secrets) to the node.
For solving this issue, this commit introduces an alternative authentication method based on CRI proxy.
This allows stargz snapshotter to work as a proxy of CRI Image Service. Stargz Snapshotter exposes CRI Image Service API on its unix socket (i.e.
/run/containerd-stargz-grpc/containerd-stargz-grpc.sock). It acquires registry creds by scanning requests on CRI PullImage API.The following configuration enables this authentication mode.
--image-service-endpoint=unix:///run/containerd-stargz-grpc/containerd-stargz-grpc.sockoption is needed to kubelet.