If streams cannot be locked, it will cause a panic

Signed-off-by: jokemanfire <[email protected]>
containerd · Aug 8, 2024 · 01c2d73 · 01c2d73
1 parent 152ac12
commit 01c2d73
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/src/asynchronous/client.rs b/src/asynchronous/client.rs
@@ -74,8 +74,12 @@ impl Client {
 
         let (tx, mut rx): (ResultSender, ResultReceiver) = mpsc::channel(100);
 
-        // TODO: check return.
-        self.streams.lock().unwrap().insert(stream_id, tx);
+        if let Ok(mut streams) = self.streams.lock() {
+            streams.insert(stream_id, tx);
+        } else {
+            return Err(Error::Others("Failed to acquire lock on streams".to_string()));
+        }
+
 
         self.req_tx
             .send(msg)
@@ -136,8 +140,12 @@ impl Client {
         }
 
         let (tx, rx): (ResultSender, ResultReceiver) = mpsc::channel(100);
-        // TODO: check return
-        self.streams.lock().unwrap().insert(stream_id, tx);
+        if let Ok(mut streams) = self.streams.lock() {
+            streams.insert(stream_id, tx);
+        } else {
+            return Err(Error::Others("Failed to acquire lock on streams".to_string()));
+        }
+
         self.req_tx
             .send(msg)
             .await