Codegen: convert Arc<Box<T>> to Arc<T>

This commit changes the generated ttrpc server from Arc<Box<T>> to Arc<T>. This helps the type conversion and also avoids extra runtime cost caused by double pointer. Fixes #234 Signed-off-by: Xynnn007 <[email protected]>
containerd · Sep 9, 2024 · 1f2a266 · 1f2a266
1 parent 152ac12
commit 1f2a266
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/compiler/src/codegen.rs b/compiler/src/codegen.rs
@@ -145,7 +145,7 @@ impl<'a> MethodGen<'a> {
             "}",
             |w| {
                 w.write_line(&format!(
-                    "service: Arc<Box<dyn {} + Send + Sync>>,",
+                    "service: Arc<dyn {} + Send + Sync>,",
                     self.service_name
                 ));
             },
@@ -558,7 +558,7 @@ impl<'a> ServiceGen<'a> {
     fn write_sync_server_create(&self, w: &mut CodeWriter) {
         let method_handler_name = "::ttrpc::MethodHandler";
         let s = format!(
-            "create_{}(service: Arc<Box<dyn {} + Send + Sync>>) -> HashMap<String, Box<dyn {} + Send + Sync>>",
+            "create_{}(service: Arc<dyn {} + Send + Sync>) -> HashMap<String, Box<dyn {} + Send + Sync>>",
             to_snake_case(&self.service_name()),
             self.service_name(),
             method_handler_name,
@@ -577,7 +577,7 @@ impl<'a> ServiceGen<'a> {
 
     fn write_async_server_create(&self, w: &mut CodeWriter) {
         let s = format!(
-            "create_{}(service: Arc<Box<dyn {} + Send + Sync>>) -> HashMap<String, {}>",
+            "create_{}(service: Arc<dyn {} + Send + Sync>) -> HashMap<String, {}>",
             to_snake_case(&self.service_name()),
             self.service_name(),
             "::ttrpc::r#async::Service"
@@ -642,7 +642,6 @@ fn write_generated_common(w: &mut CodeWriter) {
     w.write_line("#![cfg_attr(rustfmt, rustfmt_skip)]");
     w.write_line("#![allow(unknown_lints)]");
     w.write_line("#![allow(clipto_camel_casepy)]");
-    w.write_line("#![allow(box_pointers)]");
     w.write_line("#![allow(dead_code)]");
     w.write_line("#![allow(missing_docs)]");
     w.write_line("#![allow(non_camel_case_types)]");