stream: public stream related types #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #196 +/- ##
=======================================
Coverage 24.47% 24.47%
=======================================
Files 17 17
Lines 2521 2521
=======================================
Hits 617 617
Misses 1904 1904 ☔ View full report in Codecov by Sentry. |
jsturtevant
reviewed
Jun 22, 2023
| @@ -16,8 +16,9 @@ pub mod shutdown; | |||
| mod unix_incoming; | |||
|
|
|||
| pub use self::stream::{ | |||
| ClientStream, ClientStreamReceiver, ClientStreamSender, Kind, ServerStream, | |||
There was a problem hiding this comment.
Kind is dropped here. Is that intentional?
There was a problem hiding this comment.
Thanks, my fault, fixed.
Fixes: containerd#195 Signed-off-by: wanglei01 <[email protected]>
Tim-Zhang
approved these changes
Jul 3, 2023
lifupan
approved these changes
Jul 6, 2023
Tim-Zhang
added a commit
to Tim-Zhang/ttrpc-rust
that referenced
this pull request
Aug 22, 2023
Cut the release for containerd#196, containerd#197, containerd#200, containerd#203, containerd#208 Signed-off-by: Tim Zhang <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #195