Add gen mod for more convenient to use #232
Open
+39
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jokemanfire, I think it would be better if you can add some UT or directly use gen_mod in the example. thanks |
|
BTW, The CI failed |
Tim-Zhang
reviewed
Sep 26, 2024
OK I will change it. |
jokemanfire
force-pushed
the
dev
branch
2 times, most recently
from
767db9b
to
088d8b1
Compare
|
@jokemanfire I have formatted the code and have deleted |
Tim-Zhang
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
LGTM, thanks @jokemanfire, @lifupan, @teawater, @wllenyj PTAL, thanks
while use customize ,you can use gen_mod to generate mod.rs. Signed-off-by: jokemanfire <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while use customize ,you can use gen_mod to generate mod.rs.