Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v0.5] Lock Rust version to 1.77.0 for CI stability and fix warnings #244

Merged
merged 2 commits into from
Sep 24, 2024
Merged

[v0.5] Lock Rust version to 1.77.0 for CI stability and fix warnings #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
786bd0e
Fix clippy warnings for rust 1.77.0
Tim-Zhang Sep 23, 2024
4db7788
Lock rust vertion to 1.77.0 for CI stability
Tim-Zhang Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ fn main() {
#[allow(clippy::needless_borrow)]
protobuf_codegen_pure::Codegen::new()
.out_dir(out_dir)
.inputs(&["src/ttrpc.proto"])
.inputs(["src/ttrpc.proto"])
.include("src")
.run()
.expect("Codegen failed.");
Expand Down
4 changes: 4 additions & 0 deletions rust-toolchain.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
[toolchain]
channel="1.77.0"
profile="default"
components=["rustfmt", "clippy"]
14 changes: 0 additions & 14 deletions src/asynchronous/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
// SPDX-License-Identifier: Apache-2.0
//

use nix::unistd::close;
use protobuf::{CodedInputStream, Message};
use std::collections::HashMap;
use std::os::unix::io::RawFd;
Expand Down Expand Up @@ -158,19 +157,6 @@ impl Client {
}
}

struct ClientClose {
fd: RawFd,
close_fd: RawFd,
}

impl Drop for ClientClose {
fn drop(&mut self) {
close(self.close_fd).unwrap();
close(self.fd).unwrap();
trace!("All client is droped");
}
}

// Spwan a task and transfer the response
fn spawn_trans_resp(
req_map: Arc<Mutex<HashMap<u32, ResponseSender>>>,
Expand Down
Loading