Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examine cases where plugins return error on DEL #441

Closed
bboreham opened this issue Jan 22, 2020 · 3 comments
Closed

Examine cases where plugins return error on DEL #441

bboreham opened this issue Jan 22, 2020 · 3 comments
Assignees

Comments

@bboreham
Copy link
Contributor

#438 appears to have been caused by a typo where the code was special-casing 'not found', but in practice it is hardly ever a good idea to return an error from DEL because runtimes like Kubernetes will simply repeat the operation forever.

This issue is to remind us to review all error returns from DEL in the plugins in this repo.

@mars1024 mars1024 self-assigned this Jan 27, 2020
@mars1024
Copy link
Member

Willing to do this :) Idempotency of DEL should be concerned.

@mars1024
Copy link
Member

BTW, CNI DEL should be designed for an absolute clean-up, even again and again.

@mars1024
Copy link
Member

mars1024 commented Jan 29, 2020

TODOs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants