pkg/ip: use type cast instead of untrusty error message #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruce Ma <[email protected]>
jellonek
approved these changes
Jan 29, 2020
There was a problem hiding this comment.
When we will switch to supporting only golang >=1.13 it would be best to switch that to https://golang.org/pkg/errors/#Is but at the moment - this is the best what we IMO can have.
bboreham
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error message is untrusty.
From vishvananda/netlink@99091d8 and codes, we can see that there are three kinds of error message about not found
Link %s not foundLink alias %s not foundLink not foundOur judgment will obviously fail in some cases, and type cast to
LinkNotFoundErroris more proper to help distinguish not found error from others.Signed-off-by: Bruce Ma [email protected]