Fixes #342, cleanup netns after test suit #373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense. Can you squash your commits and force-push? Thanks. |
|
Yes @squeed , but how can I squash? just close this then push a new clearly commit ? |
jellonek
approved these changes
Aug 19, 2019
I think git rebase & force-push will help you :) |
mars1024
reviewed
Aug 20, 2019
| @@ -234,6 +234,7 @@ var _ = Describe("base functionality", func() { | |||
|
|
|||
| AfterEach(func() { | |||
| originalNS.Close() | |||
There was a problem hiding this comment.
Could you help to change this to Expect(originalNS.Close()).To(Succeed()) ?
There was a problem hiding this comment.
Yes, I will do it, thank you @mars1024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #342, cleanup netns after test suit