Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When prevResults are not supplied to loopback plugin, create results to return #383

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

mccv1r0
Copy link
Member

@mccv1r0 mccv1r0 commented Sep 6, 2019

When prevResults are not returned to loopback plugin, create results to return based on the lo interface and IP address assigned inside container.

Fixes 381

@mccv1r0 mccv1r0 changed the title When prevResults are not returned to loopback plugin, create results to return When prevResults are not supplied to loopback plugin, create results to return Sep 9, 2019
@bboreham
Copy link
Contributor

LGTM if we can have one or two tests.

…to return based on

the lo interface and IP address assigned inside container.

Signed-off-by: Michael Cambria <[email protected]>
Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dcbw
Copy link
Member

dcbw commented Sep 11, 2019

/lgtm

@dcbw dcbw merged commit 23d5525 into containernetworking:master Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pods creating failed because of "cannot convert: no valid IP addresses" in master branch
3 participants