Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vlan: add MTU validation to loadNetConf #405

Merged

Conversation

mars1024
Copy link
Member

Try to fix #393

Same like #404 , vlan plugin has the same problem if we want to create a vlan interface from a parent(master) interface with greater MTU.

[root@test ~]# ip link show eth2
11: eth2: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP mode DEFAULT group default qlen 1000
    link/ether fa:f2:3b:5a:33:02 brd ff:ff:ff:ff:ff:ff
[root@test ~]# ip link add link eth2 name eth2.100 mtu 2000 type vlan id 100
RTNETLINK answers: Invalid argument
[root@test ~]# ip link add link eth2 name eth2.100 mtu 1200 type vlan id 100
[root@test ~]# ip link show eth2.100
15: eth2.100@eth2: <BROADCAST,MULTICAST> mtu 1200 qdisc noop state DOWN mode DEFAULT group default qlen 1000
link/ether fa:f2:3b:5a:33:02 brd ff:ff:ff:ff:ff:ff

@dcbw
Copy link
Member

dcbw commented Nov 6, 2019

/lgtm

@squeed
Copy link
Member

squeed commented Nov 6, 2019

👍

@bboreham bboreham merged commit 825fbd8 into containernetworking:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve MTU assignment and validation
4 participants