Fix for the case where kernel doesn't have CONFIG_BRIDGE_VLAN_FILTERING #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jellonek
approved these changes
Jan 10, 2020
If the Linux kernel is not built with the parameter CONFIG_BRIDGE_VLAN_FILTERING, passing vlanFiltering in the Bridge struct returns an error creating the bridge interface. This happens even when no parameter is set on Vlan in the CNI config. This change fixes the case where no Vlan parameter is configured on CNI config file so the flag doesn't need to be included in the struct. Signed-off-by: Carlos de Paula <[email protected]>
|
The forced push was to update the commit message. Thank you for looking at this quickly for us. |
Nitpick: also if Vlan is configured as |
|
Thanks @bboreham What needs to happen to get a patch release made up with binaries? We can keep maintaining a fork, but it would be nice to switch over to upstream again as soon as we can. |
|
We plan to do release "quickly" but I can not guarantee if that will be in a week or two. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Linux kernel is not built with the parameter CONFIG_BRIDGE_VLAN_FILTERING, passing
vlanFilteringin the Bridge struct returns an error creating the bridge interface. This happens even when no parameter is set onVlanin the CNI config.This change fixes the case where no
Vlanparameter is configured on CNI config file so the flag doesn't need to be included in the struct.Addresses problems related in issue #370 seen on the Raspberry Pi kernel.
Cc. @alexellis