ipam/dhcp: Add broadcast flag #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahhausler
force-pushed
the
dhcp-broadcast
branch
from
8a7b8d9
to
55e6447
Compare
mars1024
reviewed
Jan 28, 2021
micahhausler
force-pushed
the
dhcp-broadcast
branch
2 times, most recently
from
5709d9a
to
6029bdf
Compare
Signed-off-by: Micah Hausler <[email protected]>
micahhausler
force-pushed
the
dhcp-broadcast
branch
from
6029bdf
to
11af59e
Compare
|
Need anything else here? |
|
Looks good to me. Can you add a PR to the docs repository - https://github.com/containernetworking/cni.dev/ - documenting this? Thanks! |
Done in containernetworking/cni.dev#79 |
This was referenced Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting this new flag resolves #440 for me