[macvlan] Stop setting proxy-arp on macvlan interface #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original issue was: containernetworking/cni#84 I've added "a fix" for it in containernetworking/cni#149 which then was merged in containernetworking/cni#177 The thing is that "the fix" was incorrect as it was setting 1 on arp_proxy (I really don't recall why) instead of setting it on arp_notify - which was my original suggestion in: rkt/rkt#1765 (comment) Setting apr_proxy can be harmfull and we have already support for sending GratuitousArpOverIface after setting an IP address, so setting any sysctl should not be needed. Signed-off-by: Piotr Skamruk <[email protected]>
squeed
approved these changes
Feb 24, 2021
mccv1r0
approved these changes
Feb 24, 2021
bboreham
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original issue was: containernetworking/cni#84
I've added "a fix" for it in
containernetworking/cni#149 which then was
merged in containernetworking/cni#177
The thing is that "the fix" was incorrect as it was setting 1 on
arp_proxy (I really don't recall why) instead of setting it on
arp_notify - which was my original suggestion in:
rkt/rkt#1765 (comment)
Setting apr_proxy can be harmfull and we have already support for
sending GratuitousArpOverIface after setting an IP address, so setting
any sysctl should not be needed.
Signed-off-by: Piotr Skamruk [email protected]