-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add spec and capabilities to sandbox run #128
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Sascha Grunert <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
==========================================
+ Coverage 42.48% 43.24% +0.75%
==========================================
Files 47 47
Lines 5359 5425 +66
==========================================
+ Hits 2277 2346 +69
+ Misses 3082 3079 -3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks like a good step but we should add it for a different InfraContainerSandbox
. We don't need the spec for the PinnedSandbox
:) I have a WIP for PinnedSandbox
I will push tomorrow.
Ah okay, that's interesting. Now I'm wondering how we could apply capabilities without a spec 😇 |
@saschagrunert: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This adds the runtime spec creation as well as the capability handling to the sandbox run method.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?