Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: some small improvements and enable overlay driver for podman #1312

Merged
merged 6 commits into from
Sep 27, 2023

Conversation

giuseppe
Copy link
Member

No description provided.

@giuseppe giuseppe changed the title [WIP][DO NOT MERGE] tests: enable cri-o tests [WIP][DO NOT MERGE] tests: improve tests Sep 26, 2023
@giuseppe giuseppe force-pushed the improve-podman-tests branch 2 times, most recently from c6d32ae to d378f2f Compare September 26, 2023 14:18
@giuseppe giuseppe force-pushed the improve-podman-tests branch 2 times, most recently from 6a4a0cb to 33ea630 Compare September 26, 2023 16:48
@giuseppe
Copy link
Member Author

we need containers/storage#1722 before we can enable the uidmapping and gidmapping with a volume test

@giuseppe giuseppe changed the title [WIP][DO NOT MERGE] tests: improve tests tests: some small improvements and enable overlay driver for podman Sep 27, 2023
@giuseppe
Copy link
Member Author

@flouthoc PTAL this is ready (once the CI is green)

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flouthoc
Copy link
Collaborator

@giuseppe Could you undraft this PR

Signed-off-by: Giuseppe Scrivano <[email protected]>
@giuseppe giuseppe marked this pull request as ready for review September 27, 2023 08:51
@flouthoc flouthoc merged commit c7db23d into containers:main Sep 27, 2023
38 checks passed
@flouthoc
Copy link
Collaborator

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants