-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: some small improvements and enable overlay driver for podman #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe
changed the title
[WIP][DO NOT MERGE] tests: enable cri-o tests
[WIP][DO NOT MERGE] tests: improve tests
Sep 26, 2023
giuseppe
force-pushed
the
improve-podman-tests
branch
2 times, most recently
from
September 26, 2023 14:18
c6d32ae
to
d378f2f
Compare
giuseppe
force-pushed
the
improve-podman-tests
branch
2 times, most recently
from
September 26, 2023 16:48
6a4a0cb
to
33ea630
Compare
Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
improve-podman-tests
branch
2 times, most recently
from
September 26, 2023 20:11
560aff1
to
af706f3
Compare
giuseppe
force-pushed
the
improve-podman-tests
branch
from
September 27, 2023 07:50
af706f3
to
8897fe7
Compare
we need containers/storage#1722 before we can enable the |
giuseppe
changed the title
[WIP][DO NOT MERGE] tests: improve tests
tests: some small improvements and enable overlay driver for podman
Sep 27, 2023
@flouthoc PTAL this is ready (once the CI is green) |
flouthoc
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@giuseppe Could you undraft this PR |
Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
improve-podman-tests
branch
from
September 27, 2023 08:51
8897fe7
to
8f6b76f
Compare
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.