Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packit: switch to rpm/gvisor-tap-vsock.spec #247

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Jul 24, 2023

gvisor-tap-vsock has now been included as a separate Fedora package.

This commit also enables downstream Fedora packaging tasks on upstream
release.

@packit-as-a-service
Copy link

Failed to load packit config file:

Please correct data and retry.

For more info, please check out the documentation or contact the Packit team.

@lsm5
Copy link
Member Author

lsm5 commented Jul 24, 2023

rpm-build:fedora-rawhide-* is going to fail until upstream is fixed to build with go1.21. Those task failures are best ignored for now.

@cfergeau
Copy link
Contributor

Is this PR still needed? I've rebased it in https://github.com/cfergeau/gvisor-tap-vsock/tree/packit-update

@lsm5
Copy link
Member Author

lsm5 commented Jul 28, 2023

I need to rebase this on main.

@cfergeau
Copy link
Contributor

I need to rebase this on main.

@lsm5 I've already done this in https://github.com/cfergeau/gvisor-tap-vsock/tree/packit-update

@lsm5 lsm5 force-pushed the packit-update branch 2 times, most recently from 97e3fb9 to 06d1116 Compare July 28, 2023 12:48
@cfergeau
Copy link
Contributor

The centos-stream builds are failing, the centos-stream-8 builds complain about a missing 'go-rpm-macros' package, the centos-stream-9 builds complain about the aarch64/x86_64 architectures not being included(?)

@lsm5
Copy link
Member Author

lsm5 commented Jul 28, 2023

conditionalized go-rpm-macros. The c9s failure are a result of a faulty %{golang_arches_future} which I'm checking on with the toolset team. We can ignore c9s for now.

@lsm5 lsm5 force-pushed the packit-update branch 3 times, most recently from d9070e1 to 1e6e15b Compare August 1, 2023 15:06
@lsm5
Copy link
Member Author

lsm5 commented Aug 1, 2023

@cfergeau PTAL

@lsm5
Copy link
Member Author

lsm5 commented Aug 1, 2023

@cfergeau once this is merged, whenever there's a new release published to github, packit will create rpm update PRs to https://src.fedoraproject.org/rpms/gvisor-tap-vsock , which will need a human to review and merge. After packit's first PR, subsequent PRs should have a minimal diff.

@lsm5
Copy link
Member Author

lsm5 commented Aug 2, 2023

This needs a small change for correct obsoletion. Updating..

gvisor-tap-vsock has now been included as a separate Fedora package.

This commit also enables downstream Fedora packaging tasks on upstream
release.

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
Copy link
Member Author

lsm5 commented Aug 2, 2023

This needs a small change for correct obsoletion. Updating..

Done.

@baude
Copy link
Member

baude commented Aug 2, 2023

/approve

@openshift-ci openshift-ci bot added the approved label Aug 2, 2023
@baude
Copy link
Member

baude commented Aug 2, 2023

LGTM

@lsm5
Copy link
Member Author

lsm5 commented Aug 2, 2023

@cfergeau this is good to go. PTAL.

@lsm5 lsm5 requested a review from cfergeau August 2, 2023 18:06
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@baude
Copy link
Member

baude commented Aug 3, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 3, 2023
@openshift-merge-robot openshift-merge-robot merged commit 62ec518 into containers:main Aug 3, 2023
15 checks passed
@lsm5 lsm5 deleted the packit-update branch August 3, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants