rpm: correctly obsolete older rpm builds #271
Conversation
| @@ -70,6 +70,10 @@ dynamic port forwarding. | |||
| %package gvforwarder | |||
| Summary: %{desc_gvforwarder} | |||
| Provides: gvforwarder = %{epoch}:%{version}-%{release} | |||
| %if !%{defined copr_username} | |||
| Obsoletes: %{name} < 6:0.7.0-6 | |||
There was a problem hiding this comment.
I haven't confirmed the -6 but otherwise LGTM. Thank you.
There was a problem hiding this comment.
@edsantiago the latest build in bodhi is -6 so this should obsolete anything less than that.
|
@Luap99 thanks, needs an approved label too |
|
I don't have the openshift permissions on this repo: https://github.com/containers/gvisor-tap-vsock/blob/main/OWNERS We can cheat by manually setting the label via github UI but I rather leave this up for actual maintainer of this repo. |
|
Sorry about the earlier nags. Converting to draft as this fix doesn't yet address the conflicts noticed in cockpit reverse dependency tests in containers/podman#19953 |
|
New changes are detected. LGTM label has been removed. |
The prior change in containers#268 didn't completely obsolete older builds of gvisor-tap-vsock, causing installation conflicts with the official Fedora builds. This commit should correctly obsolete fedora packages. Ref: https://cirrus-ci.com/task/5730166412935168 This change should also address installation conflicts in cockpit-reverse dependency tests on podman upstream Ref: https://artifacts.dev.testing-farm.io/716a3cac-ab80-4eb8-921c-da3a784b94fb/ Signed-off-by: Lokesh Mandvekar <[email protected]>
lsm5
force-pushed
the
gvforwarder-subpackage-followup
branch
from
970d1a1
to
f82824a
Compare
|
@baude PTAL |
|
i'm gonna add the labels and merge it. This doesn't affect upstream and we need this to unblock revdep tests for cockpit. |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: lsm5, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The prior change in #268 didn't completely obsolete older builds of gvisor-tap-vsock, causing installation conflicts with the official Fedora builds. This commit should correctly obsolete fedora packages.
Ref: https://cirrus-ci.com/task/5730166412935168
This change should also address installation conflicts in
cockpit-reverse dependency tests on podman upstream
Ref: https://artifacts.dev.testing-farm.io/716a3cac-ab80-4eb8-921c-da3a784b94fb/
@baude @Luap99 @edsantiago PTAL. I added the 2 latest commits from https://src.fedoraproject.org/rpms/gvisor-tap-vsock/commits/rawhide to this PR. In case you wanna manually try, you can install the latest build from https://koji.fedoraproject.org/koji/packageinfo?packageID=37521 over the gvisor already in Fedora.