Add graceful shutdown support for gvproxy on Win #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leverages WM_CLOSE and WM_QUIT events on win32 for SIGTERM like behavior The improved/updated logic is now implemented in a shared containers/winquit module Also, refactors win-sshproxy.exe to be consistent (had it's own precursor impl) Signed-off-by: Jason T. Greene <[email protected]>
n1hility
force-pushed
the
gvp-quit-handling
branch
from
2d105d3
to
77fdbaf
Compare
n1hility
changed the title
cfergeau
approved these changes
Sep 21, 2023
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, n1hility The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverages WM_CLOSE and WM_QUIT events on win32 for SIGTERM like behavior The improved/updated logic is now implemented in a shared containers/winquit module. Also, refactors win-sshproxy.exe to be consistent (had it's own precursor impl)