Narrow down the scope of a variable

Otherwise "err" refers to a variable outside of this closure, not even to the one used by the immediate caller. Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
containers · Jul 9, 2024 · 22b11d1 · 22b11d1
1 parent 871cdd3
commit 22b11d1
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/copy/single.go b/copy/single.go
@@ -490,8 +490,7 @@ func (ic *imageCopier) copyLayers(ctx context.Context) ([]compressiontypes.Algor
 		defer copyGroup.Wait()
 
 		for i, srcLayer := range srcInfos {
-			err = ic.c.concurrentBlobCopiesSemaphore.Acquire(ctx, 1)
-			if err != nil {
+			if err := ic.c.concurrentBlobCopiesSemaphore.Acquire(ctx, 1); err != nil {
 				// This can only fail with ctx.Err(), so no need to blame acquiring the semaphore.
 				return fmt.Errorf("copying layer: %w", err)
 			}