Ensure we close idle connections (if any) in the openshift transport

Signed-off-by: Miloslav Trmač <[email protected]>

openshift/openshift.go

@@ -65,6 +65,10 @@ func newOpenshiftClient(ref openshiftReference) (*openshiftClient, error) {
 	}, nil
 }
 
+func (c *openshiftClient) close() {
+	c.httpClient.CloseIdleConnections()
+}
+
 // doRequest performs a correctly authenticated request to a specified path, and returns response body or an error object.
 func (c *openshiftClient) doRequest(ctx context.Context, method, path string, requestBody []byte) ([]byte, error) {
 	requestURL := *c.baseURL

openshift/openshift_dest.go

@@ -71,7 +71,9 @@ func (d *openshiftImageDestination) Reference() types.ImageReference {
 
 // Close removes resources associated with an initialized ImageDestination, if any.
 func (d *openshiftImageDestination) Close() error {
-	return d.docker.Close()
+	err := d.docker.Close()
+	d.client.close()
+	return err
 }
 
 func (d *openshiftImageDestination) SupportedManifestMIMETypes() []string {

openshift/openshift_src.go

@@ -60,14 +60,15 @@ func (s *openshiftImageSource) Reference() types.ImageReference {
 
 // Close removes resources associated with an initialized ImageSource, if any.
 func (s *openshiftImageSource) Close() error {
+	var err error
 	if s.docker != nil {
-		err := s.docker.Close()
+		err = s.docker.Close()
 		s.docker = nil
-
-		return err
 	}
 
-	return nil
+	s.client.close()
+
+	return err
 }
 
 // GetManifest returns the image's manifest along with its MIME type (which may be empty when it can't be determined but the manifest is available).