Move prefix validation to postProcessRegistries #1369
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsm5
changed the title
Previously an unset Location was only allowed for wildcarded Prefixes. This commit will allow configs with emtpy location or empty prefix, so long as the other is valid. Remove wildcard prefix check for empty location in rewriteReference. Fixes: 1. containers#1191 (comment) 2. containers#1191 (comment) Co-authored-by: Miloslav Trmač <[email protected]> Signed-off-by: Lokesh Mandvekar <[email protected]>
Fixes: containers#1191 (comment) Signed-off-by: Lokesh Mandvekar <[email protected]>
lsm5
force-pushed
the
wildcard-cert-fixes-3
branch
from
81627a4
to
63bb4cb
Compare
Empty location is now allowed with a valid prefix, and we check for these in postProcessRegistries already. This check doesn't need to exist. Fixes: containers#1191 (comment) Signed-off-by: Lokesh Mandvekar <[email protected]>
lsm5
force-pushed
the
wildcard-cert-fixes-3
branch
from
85d3927
to
29d476d
Compare
|
(Marking as draft to reflect the dependency on #1368 .) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1368 .
@vrothberg @mtrmac @ashcrow PTAL